Skip to content

Fix: DoS script issues and headline level issues #1480

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Nov 27, 2025
Merged

Fix: DoS script issues and headline level issues #1480

merged 3 commits into from
Nov 27, 2025

Conversation

@aknot242
Copy link
Collaborator

@aknot242 aknot242 commented Nov 24, 2025 •
edited
Loading

Proposed changes

  • The docker entrypoint's chmod command was corrupt
  • The WAF + DoS entrypoint was missing a critical line break
  • The Kubernetes examples were incorrectly falling under SELinux in the ToC
  • To fix an NGINX config load error, moving probe directives to http context as that is the only valid location for them

Checklist

Before sharing this pull request, I completed the following checklist:

Footnotes

  1. Potentially sensitive information includes personally identify information (PII), authentication credentials, and live URLs. Refer to the style guide for guidance about placeholder content. ↩

@aknot242 aknot242 requested a review from a team as a code owner November 24, 2025 15:17
@github-actions github-actions bot added documentation Improvements or additions to documentation product/dos Issues related to F5 DoS for NGINX labels Nov 24, 2025
@github-actions
Copy link

github-actions bot commented Nov 24, 2025

✅ Deploy Preview will be available once build job completes!

Name Link
😎 Deploy Preview https://frontdoor-test-docs.nginx.com/previews/docs/1480/

ADubhlaoich
ADubhlaoich approved these changes Nov 24, 2025
View reviewed changes
Copy link
Member

@ADubhlaoich ADubhlaoich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Adding WAF approvers for tagging.

@ADubhlaoich ADubhlaoich requested a review from a team November 24, 2025 15:23
@EyalPery
Copy link
Contributor

EyalPery commented Nov 25, 2025

I currently don't have the option to approve but as the DOS developer, I approve the changes.

@ADubhlaoich ADubhlaoich merged commit 9029d8f into main Nov 27, 2025
7 checks passed
@ADubhlaoich ADubhlaoich deleted the fix-dos-scripts branch November 27, 2025 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ADubhlaoich ADubhlaoich ADubhlaoich approved these changes

@mouraddmeiri mouraddmeiri mouraddmeiri approved these changes

@ohad-perets ohad-perets ohad-perets approved these changes

Assignees

No one assigned

Labels

documentation Improvements or additions to documentation product/dos Issues related to F5 DoS for NGINX

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@aknot242 @EyalPery @ADubhlaoich @mouraddmeiri @ohad-perets